]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: phy: realtek: Dummy IRQ calls for RTL8366RB
authorLinus Walleij <linus.walleij@linaro.org>
Sun, 24 Feb 2019 00:11:15 +0000 (01:11 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 24 Feb 2019 02:45:28 +0000 (18:45 -0800)
commit4c8e0459b585e2a7b367545be3e102737f1e489f
treefd87c219b0556bf0eac5e2509896261dca11b0e2
parentbf50b606cfd85ac8d3d0adb711f3e22204059848
net: phy: realtek: Dummy IRQ calls for RTL8366RB

This fixes a regression introduced by
commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7
"net: phy: replace PHY_HAS_INTERRUPT with a check for
config_intr and ack_interrupt".

This assumes that a PHY cannot trigger interrupt unless
it has .config_intr() or .ack_interrupt() implemented.
A later patch makes the code assume both need to be
implemented for interrupts to be present.

But this PHY (which is inside a DSA) will happily
fire interrupts without either callback.

Implement dummy callbacks for .config_intr() and
.ack_interrupt() in the phy header to fix this.

Tested on the RTL8366RB on D-Link DIR-685.

Fixes: 0d2e778e38e0 ("net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt")
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/realtek.c
include/linux/phy.h