]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tracing/kprobes: Fix within_notrace_func() to check only notrace functions
authorMasami Hiramatsu <mhiramat@kernel.org>
Thu, 2 Aug 2018 07:50:48 +0000 (16:50 +0900)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 2 Aug 2018 16:34:41 +0000 (12:34 -0400)
commit6bc6c77cfc6747292d5865d124cc31333b1b8536
treed1099447d280fb8fa96019fc6dab2d23e904f424
parent44ec3ec01fb7d54d1a14c138cb43b90a0e934b89
tracing/kprobes: Fix within_notrace_func() to check only notrace functions

Fix within_notrace_func() to check only notrace functions and to ignore the
kprobe-event which can not solve symbol addresses.

within_notrace_func() returns true if the given kprobe events probe point
seems to be out-of-range. But that is not the correct place to check for it,
it should be done in kprobes afterwards.

kprobe-events allow users to define a probe point on "currently unloaded
module" so that it can trace the event during module load. In this case, the
user will put a probe on a symbol which is not in kallsyms yet and it hits
the within_notrace_func().  As a result, kprobe-events always refuses if
user defines a probe on a "currenly unloaded module".

Fixes: commit 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
Link: http://lkml.kernel.org/r/153319624799.29007.13604430345640129926.stgit@devbox
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c