]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
eth: bnxt: fix counting packets discarded due to OOM and netpoll
authorJakub Kicinski <kuba@kernel.org>
Wed, 24 Apr 2024 00:21:48 +0000 (17:21 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 Apr 2024 03:16:43 +0000 (20:16 -0700)
commit730117730709992c9f6535dd7b47638ee561ec45
tree7c5762fd7cdd3f0f77ec13eb29279cfcd77f9aec
parentc04d1b9ecce565455652ac3c6b17043cd475cf47
eth: bnxt: fix counting packets discarded due to OOM and netpoll

I added OOM and netpoll discard counters, naively assuming that
the cpr pointer is pointing to a common completion ring.
Turns out that is usually *a* completion ring but not *the*
completion ring which bnapi->cp_ring points to. bnapi->cp_ring
is where the stats are read from, so we end up reporting 0
thru ethtool -S and qstat even though the drop events have happened.
Make 100% sure we're recording statistics in the correct structure.

Fixes: 907fd4a294db ("bnxt: count discards due to memory allocation errors")
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20240424002148.3937059-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c