]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dm mirror log: clear log bits up to BITS_PER_LONG boundary
authorMikulas Patocka <mpatocka@redhat.com>
Thu, 23 Jun 2022 18:53:25 +0000 (14:53 -0400)
committerMike Snitzer <snitzer@kernel.org>
Thu, 23 Jun 2022 18:55:43 +0000 (14:55 -0400)
commit90736eb3232d208ee048493f371075e4272e0944
treea0b517d7e5c9a85495b58e9def970af84b669cc2
parent61b6e2e5321da281ab3c0c04e1962b3d000f6248
dm mirror log: clear log bits up to BITS_PER_LONG boundary

Commit 85e123c27d5c ("dm mirror log: round up region bitmap size to
BITS_PER_LONG") introduced a regression on 64-bit architectures in the
lvm testsuite tests: lvcreate-mirror, mirror-names and vgsplit-operation.

If the device is shrunk, we need to clear log bits beyond the end of the
device. The code clears bits up to a 32-bit boundary and then calculates
lc->sync_count by summing set bits up to a 64-bit boundary (the commit
changed that; previously, this boundary was 32-bit too). So, it was using
some non-zeroed bits in the calculation and this caused misbehavior.

Fix this regression by clearing bits up to BITS_PER_LONG boundary.

Fixes: 85e123c27d5c ("dm mirror log: round up region bitmap size to BITS_PER_LONG")
Cc: stable@vger.kernel.org
Reported-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-log.c