]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iommu/virtio: Add __counted_by for struct viommu_request and use struct_size()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 9 Oct 2023 18:24:27 +0000 (12:24 -0600)
committerJoerg Roedel <jroedel@suse.de>
Mon, 16 Oct 2023 07:37:31 +0000 (09:37 +0200)
commit9e13ec61de2a51195b122a79461431d8cb99d7b5
tree2b22f00a73489d5b278e8c69a162db70b55005e1
parent6465e260f48790807eef06b583b38ca9789b6072
iommu/virtio: Add __counted_by for struct viommu_request and use struct_size()

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/ZSRFW0yDlDo8+at3@work
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/virtio-iommu.c