]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: amd: renoir: restore two more registers during resume
authorHui Wang <hui.wang@canonical.com>
Thu, 30 Jul 2020 12:31:38 +0000 (20:31 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 3 Aug 2020 13:17:34 +0000 (14:17 +0100)
commitccff7bd468d5e0595176656a051ef67c01f01968
treece393c5b7fff1296d2e47210e2d36a793f845c2a
parentb023666e6c0165651de18cabcbb65ba14f2db153
ASoC: amd: renoir: restore two more registers during resume

Recently we found an issue about the suspend and resume. If dmic is
recording the sound, and we run suspend and resume, after the resume,
the dmic can't work well anymore. we need to close the app and reopen
the app, then the dmic could record the sound again.

For example, we run "arecord -D hw:CARD=acp,DEV=0 -f S32_LE -c 2
-r 48000 test.wav", then suspend and resume, after the system resume
back, we speak to the dmic. then stop the arecord, use aplay to play
the test.wav, we could hear the sound recorded after resume is weird,
it is not what we speak to the dmic.

I found two registers are set in the dai_hw_params(), if the two
registers are set during the resume, this issue could be fixed.
Move the code of the dai_hw_params() into the pdm_dai_trigger(), then
these two registers will be set during resume since pdm_dai_trigger()
will be called during resume. And delete the empty function
dai_hw_params().

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200730123138.5659-1-hui.wang@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/renoir/acp3x-pdm-dma.c