]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: gtp: Fix Use-After-Free in gtp_dellink
authorHyunwoo Kim <v4bel@theori.io>
Mon, 22 Apr 2024 09:39:30 +0000 (05:39 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Apr 2024 10:46:31 +0000 (11:46 +0100)
commitf2a904107ee2b647bb7794a1a82b67740d7c8a64
tree1ce6bfa0f7b1b969617d26531f72e8476ae1640a
parent80e679b352c3ce5158f3f778cfb77eb767e586fb
net: gtp: Fix Use-After-Free in gtp_dellink

Since call_rcu, which is called in the hlist_for_each_entry_rcu traversal
of gtp_dellink, is not part of the RCU read critical section, it
is possible that the RCU grace period will pass during the traversal and
the key will be free.

To prevent this, it should be changed to hlist_for_each_entry_safe.

Fixes: 94dc550a5062 ("gtp: fix an use-after-free in ipv4_pdp_find()")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/gtp.c