]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pNFS: Fix a hang in nfs4_evict_inode()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 8 Oct 2023 18:20:19 +0000 (14:20 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 18 Oct 2023 18:41:52 +0000 (14:41 -0400)
commitf63955721a8020e979b99cc417dcb6da3106aa24
tree2396587080a0b5a0fb721d5406ddaf80a855dfe7
parent6a6d4644ce935ddec4f76223ac0ca68da56bd2d3
pNFS: Fix a hang in nfs4_evict_inode()

We are not allowed to call pnfs_mark_matching_lsegs_return() without
also holding a reference to the layout header, since doing so could lead
to the reference count going to zero when we call
pnfs_layout_remove_lseg(). This again can lead to a hang when we get to
nfs4_evict_inode() and are unable to clear the layout pointer.

pnfs_layout_return_unused_byserver() is guilty of this behaviour, and
has been seen to trigger the refcount warning prior to a hang.

Fixes: b6d49ecd1081 ("NFSv4: Fix a pNFS layout related use-after-free race when freeing the inode")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/pnfs.c