From: Sasha Levin Date: Fri, 19 Apr 2019 13:48:35 +0000 (-0400) Subject: fixes for 4.19 X-Git-Tag: v4.9.170~9 X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fkernel%2Fstable-queue.git;a=commitdiff_plain;h=ebd1ab140a7191237ae75c08a64bfddada81438a fixes for 4.19 Signed-off-by: Sasha Levin --- diff --git a/queue-4.19/appletalk-fix-compile-regression.patch b/queue-4.19/appletalk-fix-compile-regression.patch new file mode 100644 index 0000000000..c9ef3c4c8a --- /dev/null +++ b/queue-4.19/appletalk-fix-compile-regression.patch @@ -0,0 +1,69 @@ +From 6a47483c25635f37e5ccb540abdeaab325162703 Mon Sep 17 00:00:00 2001 +From: Arnd Bergmann +Date: Wed, 6 Mar 2019 11:52:36 +0100 +Subject: appletalk: Fix compile regression + +[ Upstream commit 27da0d2ef998e222a876c0cec72aa7829a626266 ] + +A bugfix just broke compilation of appletalk when CONFIG_SYSCTL +is disabled: + +In file included from net/appletalk/ddp.c:65: +net/appletalk/ddp.c: In function 'atalk_init': +include/linux/atalk.h:164:34: error: expected expression before 'do' + #define atalk_register_sysctl() do { } while(0) + ^~ +net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl' + rc = atalk_register_sysctl(); + +This is easier to avoid by using conventional inline functions +as stubs rather than macros. The header already has inline +functions for other purposes, so I'm changing over all the +macros for consistency. + +Fixes: 6377f787aeb9 ("appletalk: Fix use-after-free in atalk_proc_exit") +Signed-off-by: Arnd Bergmann +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/linux/atalk.h | 18 ++++++++++++++---- + 1 file changed, 14 insertions(+), 4 deletions(-) + +diff --git a/include/linux/atalk.h b/include/linux/atalk.h +index 5a90f28d5ff2..d5cfc0b15b76 100644 +--- a/include/linux/atalk.h ++++ b/include/linux/atalk.h +@@ -161,16 +161,26 @@ extern int sysctl_aarp_resolve_time; + extern int atalk_register_sysctl(void); + extern void atalk_unregister_sysctl(void); + #else +-#define atalk_register_sysctl() do { } while(0) +-#define atalk_unregister_sysctl() do { } while(0) ++static inline int atalk_register_sysctl(void) ++{ ++ return 0; ++} ++static inline void atalk_unregister_sysctl(void) ++{ ++} + #endif + + #ifdef CONFIG_PROC_FS + extern int atalk_proc_init(void); + extern void atalk_proc_exit(void); + #else +-#define atalk_proc_init() ({ 0; }) +-#define atalk_proc_exit() do { } while(0) ++static inline int atalk_proc_init(void) ++{ ++ return 0; ++} ++static inline void atalk_proc_exit(void) ++{ ++} + #endif /* CONFIG_PROC_FS */ + + #endif /* __LINUX_ATALK_H__ */ +-- +2.19.1 + diff --git a/queue-4.19/series b/queue-4.19/series index b635fd5555..2afdcb020d 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -2,7 +2,6 @@ arc-u-boot-args-check-that-magic-number-is-correct.patch arc-hsdk_defconfig-enable-config_blk_dev_ram.patch inotify-fix-fsnotify_mark-refcount-leak-in-inotify_u.patch perf-core-restore-mmap-record-type-correctly.patch -perf-data-don-t-store-auxtrace-index-for-directory-d.patch ext4-avoid-panic-during-forced-reboot.patch ext4-add-missing-brelse-in-add_new_gdb_meta_bg.patch ext4-report-real-fs-size-after-failed-resize.patch @@ -108,3 +107,4 @@ tools-include-adopt-linux-bits.h.patch ib-hfi1-failed-to-drain-send-queue-when-qp-is-put-into-error-state.patch mm-hide-incomplete-nr_indirectly_reclaimable-in-proc-zoneinfo.patch mm-hide-incomplete-nr_indirectly_reclaimable-in-sysfs.patch +appletalk-fix-compile-regression.patch