]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - drivers/media/dvb-frontends/drxd_hard.c
media: drxd_hard: better handle I2C errors
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 1 Nov 2017 21:05:53 +0000 (17:05 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 11 Dec 2017 18:13:39 +0000 (13:13 -0500)
commitf161544d9d7d8e617c13fe30504317c417ed49e9
tree2c5b68f7a98af9c2cb0643b04d454092b4fbbdef
parent07ade2d0f680864ba0c93553d008900dd3e1a421
media: drxd_hard: better handle I2C errors

As warned by smatch:
drivers/media/dvb-frontends/drxd_hard.c:989 HI_Command() error: uninitialized symbol 'waitCmd'.
drivers/media/dvb-frontends/drxd_hard.c:1306 SC_WaitForReady() error: uninitialized symbol 'curCmd'.
drivers/media/dvb-frontends/drxd_hard.c:1322 SC_SendCommand() error: uninitialized symbol 'errCode'.
drivers/media/dvb-frontends/drxd_hard.c:1339 SC_ProcStartCommand() error: uninitialized symbol 'scExec'.

The error handling on several places are somewhat flawed, as
they don't check if Read16() returns an error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/drxd_hard.c