]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtc: sh: Fix invalid alarm warning for non-enabled alarm
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 20 Mar 2019 10:32:14 +0000 (11:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2019 07:17:18 +0000 (09:17 +0200)
commit00a9ea1b3a7dea4242a10dbf07fcbcb7d826e73d
tree8ff6d6d247b4787a5b8ddfbc1d728eb9804c90a2
parent358e9483e84ac7cfa269856fa560eca307ab57dd
rtc: sh: Fix invalid alarm warning for non-enabled alarm

[ Upstream commit 15d82d22498784966df8e4696174a16b02cc1052 ]

When no alarm has been programmed on RSK-RZA1, an error message is
printed during boot:

    rtc rtc0: invalid alarm value: 2019-03-14T255:255:255

sh_rtc_read_alarm_value() returns 0xff when querying a hardware alarm
field that is not enabled.  __rtc_read_alarm() validates the received
alarm values, and fills in missing fields when needed.
While 0xff is handled fine for the year, month, and day fields, and
corrected as considered being out-of-range, this is not the case for the
hour, minute, and second fields, where -1 is expected for missing
fields.

Fix this by returning -1 instead, as this value is handled fine for all
fields.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-sh.c