]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: line6: Use correct endpoint type for midi output
authorFabián Inostroza <soulsonceonfire@gmail.com>
Thu, 12 Apr 2018 03:37:35 +0000 (00:37 -0300)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:34 +0000 (21:36 -0400)
commit04c18886ed5c9450fe96add7806ad7f03d163555
treec9bc7252d3b094f9b0d457d1c1fc70174df0248c
parentc2d4fe84bc469d2847bdb16f9e571001804fa178
ALSA: line6: Use correct endpoint type for midi output

[ Upstream commit 7ecb46e9ee9af18e304eb9e7d6804c59a408e846 ]

Sending MIDI messages to a PODxt through the USB connection shows
"usb_submit_urb failed" in dmesg and the message is not received by
the POD.

The error is caused because in the funcion send_midi_async() in midi.c
there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt
USB descriptor shows that this endpoint it's an interrupt endpoint.

Patch tested with PODxt only.

[ The bug has been present from the very beginning in the staging
  driver time, but Fixes below points to the commit moving to sound/
  directory so that the fix can be cleanly applied -- tiwai ]

Fixes: 61864d844c29 ("ALSA: move line6 usb driver into sound/usb")
Signed-off-by: Fabián Inostroza <fabianinostroza@udec.cl>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/usb/line6/midi.c