]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: fix crash on COPY_NOTIFY with special stateid
authorJ. Bruce Fields <bfields@redhat.com>
Wed, 5 Jan 2022 19:15:03 +0000 (14:15 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 8 Jan 2022 19:42:03 +0000 (14:42 -0500)
commit074b07d94e0bb6ddce5690a9b7e2373088e8b33a
treef8243be7bd9a7a5072b7c05af20d7cf1751477b4
parent7f4f5d70adfd88a08d6e122cfe2cf637ff84dd11
nfsd: fix crash on COPY_NOTIFY with special stateid

RTM says "If the special ONE stateid is passed to
nfs4_preprocess_stateid_op(), it returns status=0 but does not set
*cstid. nfsd4_copy_notify() depends on stid being set if status=0, and
thus can crash if the client sends the right COPY_NOTIFY RPC."

RFC 7862 says "The cna_src_stateid MUST refer to either open or locking
states provided earlier by the server.  If it is invalid, then the
operation MUST fail."

The RFC doesn't specify an error, and the choice doesn't matter much as
this is clearly illegal client behavior, but bad_stateid seems
reasonable.

Simplest is just to guarantee that nfs4_preprocess_stateid_op, called
with non-NULL cstid, errors out if it can't return a stateid.

Reported-by: rtm@csail.mit.edu
Fixes: 624322f1adc5 ("NFSD add COPY_NOTIFY operation")
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Olga Kornievskaia <kolga@netapp.com>
Tested-by: Olga Kornievskaia <kolga@netapp.com>
fs/nfsd/nfs4state.c