]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
brcmfmac: sdio: Disable auto-tuning around commands expected to fail
authorDouglas Anderson <dianders@chromium.org>
Mon, 17 Jun 2019 17:56:51 +0000 (10:56 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jun 2019 03:35:54 +0000 (11:35 +0800)
commit0ad82f2eb3f6f464dbc97bd8c61142e7cbb3e02f
tree2ae391aadb72b8d302983af693091131117143e4
parent31c99580687ac35a973b7bbc8fff20236540e2e5
brcmfmac: sdio: Disable auto-tuning around commands expected to fail

commit 2de0b42da263c97d330d276f5ccf7c4470e3324f upstream.

There are certain cases, notably when transitioning between sleep and
active state, when Broadcom SDIO WiFi cards will produce errors on the
SDIO bus.  This is evident from the source code where you can see that
we try commands in a loop until we either get success or we've tried
too many times.  The comment in the code reinforces this by saying
"just one write attempt may fail"

Unfortunately these failures sometimes end up causing an "-EILSEQ"
back to the core which triggers a retuning of the SDIO card and that
blocks all traffic to the card until it's done.

Let's disable retuning around the commands we expect might fail.

Cc: stable@vger.kernel.org #v4.18+
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c