]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()
authorEric Dumazet <edumazet@google.com>
Tue, 14 Jan 2020 21:00:35 +0000 (13:00 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:03:29 +0000 (19:03 +0100)
commit10a830fe87a2694c32f9d890ea700e50ab11bb78
treefe10b261105b0590d9a8a2f354c186123f0fe101
parentf042797e7c9dd3d3bef34ad547c4516e3a191741
macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()

commit 1712b2fff8c682d145c7889d2290696647d82dab upstream.

I missed the fact that macvlan_broadcast() can be used both
in RX and TX.

skb_eth_hdr() makes only sense in TX paths, so we can not
use it blindly in macvlan_broadcast()

Fixes: 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jurgen Van Ham <juvanham@gmail.com>
Tested-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/macvlan.c