]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
x86/PCI: Fix PCI IRQ routing table memory leak
authorWenwen Wang <wang6495@umn.edu>
Wed, 17 Apr 2019 14:18:50 +0000 (09:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:54 +0000 (11:54 +0200)
commit147ee2cc1044c5cc8663cd19c78e356b521574d7
tree9fb839396956bcc5c383a8c0f34ecf76cedcbf0a
parent488c10be170de73467db5856d21e0838a50ac13e
x86/PCI: Fix PCI IRQ routing table memory leak

[ Upstream commit ea094d53580f40c2124cef3d072b73b2425e7bfd ]

In pcibios_irq_init(), the PCI IRQ routing table 'pirq_table' is first
found through pirq_find_routing_table().  If the table is not found and
CONFIG_PCI_BIOS is defined, the table is then allocated in
pcibios_get_irq_routing_table() using kmalloc().  Later, if the I/O APIC is
used, this table is actually not used.  In that case, the allocated table
is not freed, which is a memory leak.

Free the allocated table if it is not used.

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
[bhelgaas: added Ingo's reviewed-by, since the only change since v1 was to
use the irq_routing_table local variable name he suggested]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/pci/irq.c