]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
test_firmware: fix error return getting clobbered
authorColin Ian King <colin.king@canonical.com>
Fri, 19 Oct 2018 12:58:01 +0000 (13:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Dec 2018 08:16:10 +0000 (09:16 +0100)
commit27b504af882ba40e4bbada1fec430ffef98f12ca
tree31ab164e6e389eeec3555f3a21a2f88b5ffaa723
parent0e3e8e31877a043c0180f2a011bae22db509d67f
test_firmware: fix error return getting clobbered

[ Upstream commit 8bb0a88600f0267cfcc245d34f8c4abe8c282713 ]

In the case where eq->fw->size > PAGE_SIZE the error return rc
is being set to EINVAL however this is being overwritten to
rc = req->fw->size because the error exit path via label 'out' is
not being taken.  Fix this by adding the jump to the error exit
path 'out'.

Detected by CoverityScan, CID#1453465 ("Unused value")

Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/test_firmware.c