]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: unsigned int compared against zero
authorColin Ian King <colin.king@canonical.com>
Sat, 11 May 2019 02:06:38 +0000 (22:06 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 11 Jun 2020 18:05:54 +0000 (19:05 +0100)
commit310dac05e090433b1de043eff9d0b0c389ba843f
tree2a324600f5edf8ca42847fb71716c76ac32fc40d
parent51890201da4d654f6ca131bc45a0e892bb10de1d
ext4: unsigned int compared against zero

commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c upstream.

There are two cases where u32 variables n and err are being checked
for less than zero error values, the checks is always false because
the variables are not signed. Fix this by making the variables ints.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/block_validity.c