]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: enforce the immutable flag on open files
authorTheodore Ts'o <tytso@mit.edu>
Mon, 10 Jun 2019 02:04:33 +0000 (22:04 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jul 2019 06:28:37 +0000 (08:28 +0200)
commit3d762b2af4824ef9e124c3c66c9eff7d2f2e470e
tree6bbf1524b12482d0dcfbd5373ae410a6d3d341dd
parente5723ddf999e8dd51e6494dfe8ee39bfccac8a35
ext4: enforce the immutable flag on open files

commit 02b016ca7f99229ae6227e7b2fc950c4e140d74a upstream.

According to the chattr man page, "a file with the 'i' attribute
cannot be modified..."  Historically, this was only enforced when the
file was opened, per the rest of the description, "... and the file
can not be opened in write mode".

There is general agreement that we should standardize all file systems
to prevent modifications even for files that were opened at the time
the immutable flag is set.  Eventually, a change to enforce this at
the VFS layer should be landing in mainline.  Until then, enforce this
at the ext4 level to prevent xfstests generic/553 from failing.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/file.c
fs/ext4/inode.c