]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
atm: Fix Use-After-Free in do_vcc_ioctl
authorHyunwoo Kim <v4bel@theori.io>
Sat, 9 Dec 2023 09:42:10 +0000 (04:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2023 14:32:32 +0000 (15:32 +0100)
commit3ddeb55deec5e0e324d0ab8cc2ddd528518ea12d
tree54e4ab4eb4828a75c3b1c799c7a8ed96e00dd3a1
parent9e8551648a456e5a14a9353c9c45d224a8f28e90
atm: Fix Use-After-Free in do_vcc_ioctl

[ Upstream commit 24e90b9e34f9e039f56b5f25f6e6eb92cdd8f4b3 ]

Because do_vcc_ioctl() accesses sk->sk_receive_queue
without holding a sk->sk_receive_queue.lock, it can
cause a race with vcc_recvmsg().
A use-after-free for skb occurs with the following flow.
```
do_vcc_ioctl() -> skb_peek()
vcc_recvmsg() -> skb_recv_datagram() -> skb_free_datagram()
```
Add sk->sk_receive_queue.lock to do_vcc_ioctl() to fix this issue.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Link: https://lore.kernel.org/r/20231209094210.GA403126@v4bel-B760M-AORUS-ELITE-AX
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/atm/ioctl.c