]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pcmcia: ds: fix refcount leak in pcmcia_device_add()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 12 Nov 2022 09:29:23 +0000 (17:29 +0800)
committerDominik Brodowski <linux@dominikbrodowski.net>
Sun, 3 Sep 2023 08:14:48 +0000 (10:14 +0200)
commit402ab979b29126068e0b596b641422ff7490214c
tree8e181df519ba6ecb189fc52bd7f8c8d0fa80b966
parente3ea1b4847e49234e691c0d66bf030bd65bb7f2b
pcmcia: ds: fix refcount leak in pcmcia_device_add()

As the comment of device_register() says, it should use put_device()
to give up the reference in the error path. Then, insofar resources
will be freed in pcmcia_release_dev(), the error path is no longer
needed. In particular, this means that the (previously missing) dropping
of the reference to &p_dev->function_config->ref is now handled by
pcmcia_release_dev().

Fixes: 360b65b95bae ("[PATCH] pcmcia: make config_t independent, add reference counting")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
[linux@dominikbrodowski.net: simplification, commit message rewrite]
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/pcmcia/ds.c