]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bug: Fix no-return-statement warning with !CONFIG_BUG
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 10 Apr 2024 15:32:12 +0000 (18:32 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 10 Apr 2024 20:01:35 +0000 (22:01 +0200)
commit5284984a4fbacb0883bfebe905902cdda2891a07
tree63a5a2161974cc4127c98cbba76e1f1a868343f3
parentf87cbcb345d059f0377b4fa0ba1b766a17fc3710
bug: Fix no-return-statement warning with !CONFIG_BUG

BUG() does not return, and arch implementations of BUG() use unreachable()
or other non-returning code. However with !CONFIG_BUG, the default
implementation is often used instead, and that does not do that. x86 always
uses its own implementation, but powerpc with !CONFIG_BUG gives a build
error:

  kernel/time/timekeeping.c: In function ‘timekeeping_debug_get_ns’:
  kernel/time/timekeeping.c:286:1: error: no return statement in function
  returning non-void [-Werror=return-type]

Add unreachable() to default !CONFIG_BUG BUG() implementation.

Fixes: e8e9d21a5df6 ("timekeeping: Refactor timekeeping helpers")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Link: https://lore.kernel.org/r/20240410153212.127477-1-adrian.hunter@intel.com
Closes: https://lore.kernel.org/all/CA+G9fYvjdZCW=7ZGxS6A_3bysjQ56YF7S-+PNLQ_8a4DKh1Bhg@mail.gmail.com/
include/asm-generic/bug.h