]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning
authorFaiz Abbas <faiz_abbas@ti.com>
Thu, 11 Apr 2019 08:59:37 +0000 (14:29 +0530)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 11 Apr 2019 10:40:32 +0000 (12:40 +0200)
commit5c41ea6d52003b5bc77c2a82fd5ca7d480237d89
tree728ed8df779df5c676d2e5308379ee50c6119935
parent157c99c5a2956a9ab1ae12de0136a2d8a1b1a307
mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning

commit 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset
callback") skips data resets during tuning operation. Because of this,
a data error or data finish interrupt might still arrive after a command
error has been handled and the mrq ended. This ends up with a "mmc0: Got
data interrupt 0x00000002 even though no data operation was in progress"
error message.

Fix this by adding a platform specific callback for sdhci_irq. Mark the
mrq as a failure but wait for a data interrupt instead of calling
finish_mrq().

Fixes: 5b0d62108b46 ("mmc: sdhci-omap: Add platform specific reset
callback")
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-omap.c