]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ip_gre: fix possible use-after-free in erspan_rcv
authorLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Sat, 6 Apr 2019 15:16:52 +0000 (17:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 06:38:43 +0000 (08:38 +0200)
commit5c6f2f4c0e9f91daa436d118a7f5c2142541e4ac
tree57811e779c510a854473d3f1f27b891266e51afe
parentecee513a5273b87ac942af435f98f31d8622b415
net: ip_gre: fix possible use-after-free in erspan_rcv

[ Upstream commit 492b67e28ee5f2a2522fb72e3d3bcb990e461514 ]

erspan tunnels run __iptunnel_pull_header on received skbs to remove
gre and erspan headers. This can determine a possible use-after-free
accessing pkt_md pointer in erspan_rcv since the packet will be 'uncloned'
running pskb_expand_head if it is a cloned gso skb (e.g if the packet has
been sent though a veth device). Fix it resetting pkt_md pointer after
__iptunnel_pull_header

Fixes: 1d7e2ed22f8d ("net: erspan: refactor existing erspan code")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ipv4/ip_gre.c