]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Wed, 3 Apr 2024 07:22:04 +0000 (15:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 10:50:12 +0000 (12:50 +0200)
commit69d1fe14a680042ec913f22196b58e2c8ff1b007
tree2d8bd9b90681fa4d54fa3da36cf6dd34dbe8531d
parentc82a659cc8bb7a7f8a8348fc7f203c412ae3636f
netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()

commit 24225011d81b471acc0e1e315b7d9905459a6304 upstream.

nft_unregister_flowtable_type() within nf_flow_inet_module_exit() can
concurrent with __nft_flowtable_type_get() within nf_tables_newflowtable().
And thhere is not any protection when iterate over nf_tables_flowtables
list in __nft_flowtable_type_get(). Therefore, there is pertential
data-race of nf_tables_flowtables list entry.

Use list_for_each_entry_rcu() to iterate over nf_tables_flowtables list
in __nft_flowtable_type_get(), and use rcu_read_lock() in the caller
nft_flowtable_type_get() to protect the entire type query process.

Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c