]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Merge branch 'ethtool-fix-use-of-SPEED_UNKNOWN-constant'
authorDavid S. Miller <davem@davemloft.net>
Mon, 8 Apr 2019 23:30:43 +0000 (16:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Apr 2019 23:30:43 +0000 (16:30 -0700)
commit738de00cda52e20c197fe4813b089e4fe5312b22
tree7892ecd5ae2e837e12153cef6ee42879214fc198
parent3c5189ad70995200bb5c15b5fc9bc81a35febcf4
parentd63da85a4226c4b5a28536a1f48d89eefd50a832
Merge branch 'ethtool-fix-use-of-SPEED_UNKNOWN-constant'

Michael Zhivich says:

====================
ethtool: fix use of SPEED_UNKNOWN constant

This patch series addresses 2 related issues:

1. ethtool_validate_speed() triggers a "signed-unsigned comparison"
warning due to type difference of SPEED_UNKNOWN constant (int)
and argument to ethtool_validate_speed (__u32).

2. some drivers use u16 storage for SPEED_UNKNOWN constant,
resulting in value truncation and thus failure to test against
SPEED_UNKNOWN correctly.

This revised series addresses several feedback comments:
- split up the patch in to series
- do not unnecessarily change drivers that use "int" storage
  for speed values
====================

Signed-off-by: David S. Miller <davem@davemloft.net>