]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5e: Switch to Toeplitz RSS hash by default
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fri, 31 Aug 2018 11:29:16 +0000 (14:29 +0300)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 9 Apr 2019 19:33:51 +0000 (12:33 -0700)
commit7ee2ace9c544a0886e02b54b625e521df8692d20
tree72daf97f1430ce26aa2b97bd5c9d27f07027ac11
parent8c8811d46d00d119ffbe039a6e52a0b504df1c2c
net/mlx5e: Switch to Toeplitz RSS hash by default

Although XOR hash function can perform very well on some special use
cases, to align with all drivers, mlx5 driver should use Toeplitz hash
by default.
Toeplitz is more stable for the general use case and it is more standard
and reliable.

On top of that, since XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only a
repeated 8 bits pattern. When used for udp tunneling RSS source port
manipulation it results in fixed source port, which will cause bad RSS
spread.

Fixes: 2be6967cdbc9 ("net/mlx5e: Support ETH_RSS_HASH_XOR")
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c