]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethtool: not call vzalloc for zero sized memory request
authorLi RongQing <lirongqing@baidu.com>
Fri, 29 Mar 2019 01:18:02 +0000 (09:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 06:38:40 +0000 (08:38 +0200)
commit80c205813d3f5d7a912c73487d1ee6d76a696af1
treeb2163a5b9b3b6a42181fa30bff22255eac69525d
parentb7b058315577de56aff6bdcd836c8ec60cdb25a4
net: ethtool: not call vzalloc for zero sized memory request

[ Upstream commit 3d8830266ffc28c16032b859e38a0252e014b631 ]

NULL or ZERO_SIZE_PTR will be returned for zero sized memory
request, and derefencing them will lead to a segfault

so it is unnecessory to call vzalloc for zero sized memory
request and not call functions which maybe derefence the
NULL allocated memory

this also fixes a possible memory leak if phy_ethtool_get_stats
returns error, memory should be freed before exit

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Wang Li <wangli39@baidu.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/ethtool.c