]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: bubble errors from ext4_find_inline_data_nolock() up to ext4_iget()
authorTheodore Ts'o <tytso@mit.edu>
Tue, 22 May 2018 21:14:07 +0000 (17:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Jun 2018 23:53:56 +0000 (07:53 +0800)
commit9d0415be6a5a33303270d2b99b93fec6c5e62730
tree19013e4a7ffb2d14decf13783b96eda35a52e7bc
parentebff7cb0666c47a7ee37dfc815fc85fcaf19be3e
ext4: bubble errors from ext4_find_inline_data_nolock() up to ext4_iget()

commit eb9b5f01c33adebc31cbc236c02695f605b0e417 upstream.

If ext4_find_inline_data_nolock() returns an error it needs to get
reflected up to ext4_iget().  In order to fix this,
ext4_iget_extra_inode() needs to return an error (and not return
void).

This is related to "ext4: do not allow external inodes for inline
data" (which fixes CVE-2018-11412) in that in the errors=continue
case, it would be useful to for userspace to receive an error
indicating that file system is corrupted.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/inode.c