]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put
authorSalam Noureddine <noureddine@aristanetworks.com>
Sun, 29 Sep 2013 20:39:42 +0000 (13:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Oct 2013 21:51:07 +0000 (14:51 -0700)
commita9092e91e01a1f1902c24d1d55cad8a472c282d0
treea67948ddc9f04924352b3c1b91b681deadfe42f1
parent8964c6487cf14fa5f00cedceab256b9aaab69acc
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put

[ Upstream commit e2401654dd0f5f3fb7a8d80dad9554d73d7ca394 ]

It is possible for the timer handlers to run after the call to
ip_mc_down so use in_dev_put instead of __in_dev_put in the handler
function in order to do proper cleanup when the refcnt reaches 0.
Otherwise, the refcnt can reach zero without the in_device being
destroyed and we end up leaking a reference to the net_device and
see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/igmp.c