]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5: SD, Handle possible devcom ERR_PTR
authorTariq Toukan <tariqt@nvidia.com>
Thu, 11 Apr 2024 11:54:40 +0000 (14:54 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 13 Apr 2024 02:13:53 +0000 (19:13 -0700)
commitaa4ac90d04f4371466000825adb44935ecb5c974
tree8c7e066faffd252008f8b0ba3a05d642e54e2557
parent37cc10da3a50e6d0cb9808a90b7da9b4868794dd
net/mlx5: SD, Handle possible devcom ERR_PTR

Check if devcom holds an error pointer and return immediately.

This fixes Smatch static checker warning:
drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c:221 sd_register()
error: 'devcom' dereferencing possible ERR_PTR()

Enhance mlx5_devcom_register_component() so it stops returning NULL,
making it easier for its callers.

Fixes: d3d057666090 ("net/mlx5: SD, Implement devcom communication and primary election")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/all/f09666c8-e604-41f6-958b-4cc55c73faf9@gmail.com/T/
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Link: https://lore.kernel.org/r/20240411115444.374475-3-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c
drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c
drivers/net/ethernet/mellanox/mlx5/core/main.c