]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kconfig: fix broken dependency in randconfig-generated .config
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 1 Feb 2020 05:03:11 +0000 (14:03 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 22 May 2020 20:19:42 +0000 (21:19 +0100)
commitb4664db5bbd36a178b75ea8b51bab921738f79b3
tree4c7692be78e9779c923b2a5117e78cac48251243
parent3a9dbf8feb3ee7ebea4c833e519f12ea3505f1e0
kconfig: fix broken dependency in randconfig-generated .config

commit c8fb7d7e48d11520ad24808cfce7afb7b9c9f798 upstream.

Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.

This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
value of CONFIG_EFI is calculated.

When this happens, the has_changed flag should be set.

Currently, it takes the result from the last iteration. It should
accumulate all the results of the loop.

Fixes: 3b9a19e08960 ("kconfig: loop as long as we changed some symbols in randconfig")
Reported-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
scripts/kconfig/confdata.c