]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ethtool: Don't omit the netlink reply if no features were changed
authorMaxim Mikityanskiy <maximmi@mellanox.com>
Mon, 17 Aug 2020 13:34:07 +0000 (16:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Aug 2020 07:30:50 +0000 (09:30 +0200)
commitb4c87df0d21c564c0af4ff4ca7a6288bc1348fbe
treee85ce0beaaa789543f36dfb128f1349ce513c6c3
parent55fc3b4d9999b5d0e52a4e7496ce6706ce65148a
ethtool: Don't omit the netlink reply if no features were changed

[ Upstream commit f01204ec8be7ea5e8f0230a7d4200e338d563bde ]

The legacy ethtool userspace tool shows an error when no features could
be changed. It's useful to have a netlink reply to be able to show this
error when __netdev_update_features wasn't called, for example:

1. ethtool -k eth0
   large-receive-offload: off
2. ethtool -K eth0 rx-fcs on
3. ethtool -K eth0 lro on
   Could not change any device features
   rx-lro: off [requested on]
4. ethtool -K eth0 lro on
   # The output should be the same, but without this patch the kernel
   # doesn't send the reply, and ethtool is unable to detect the error.

This commit makes ethtool-netlink always return a reply when requested,
and it still avoids unnecessary calls to __netdev_update_features if the
wanted features haven't changed.

Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET request")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ethtool/features.c