]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: phy: fix interrupt handling in non-started states
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 12 Feb 2019 18:56:15 +0000 (19:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2019 04:44:12 +0000 (20:44 -0800)
commitb79555d5d8d32643e9d7193341dcaff13bf9ffcd
treeeba13e945a7e44d0cc6dc4dcacac39e306e2d22e
parentaf98c5a78517c04adb5fd68bb64b1ad6fe3d473f
net: phy: fix interrupt handling in non-started states

phylib enables interrupts before phy_start() has been called, and if
we receive an interrupt in a non-started state, the interrupt handler
returns IRQ_NONE. This causes problems with at least one Marvell chip
as reported by Andrew.
Fix this by handling interrupts the same as in phy_mac_interrupt(),
basically always running the phylib state machine. It knows when it
has to do something and when not.
This change allows to handle interrupts gracefully even if they
occur in a non-started state.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c