]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mwifiex: Make resume actually do something useful again on SDIO cards
authorDouglas Anderson <dianders@chromium.org>
Thu, 4 Apr 2019 04:01:06 +0000 (21:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2019 05:21:42 +0000 (07:21 +0200)
commitbe7df63d3680f89bcdaf0b805fc213c0ff3405f8
treeb01d5d6c51b4c056307273cca600be64b76f2739
parent81a7534f9ef4ed04dff10c79db043e6c142918c0
mwifiex: Make resume actually do something useful again on SDIO cards

commit b82d6c1f8f8288f744a9dcc16cd3085d535decca upstream.

The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
adapter status variables") had a fairly straightforward bug in it.  It
contained this bit of diff:

 - if (!adapter->is_suspended) {
 + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {

As you can see the patch missed the "!" when converting to the atomic
bitops.  This meant that the resume hasn't done anything at all since
that commit landed and suspend/resume for mwifiex SDIO cards has been
totally broken.

After fixing this mwifiex suspend/resume appears to work again, at
least with the simple testing I've done.

Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
Cc: <stable@vger.kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/marvell/mwifiex/sdio.c