]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ice: Fix disabling Rx VLAN filtering with port VLAN enabled
authorBrett Creeley <brett.creeley@intel.com>
Mon, 16 Jan 2023 12:34:58 +0000 (13:34 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 6 Feb 2023 23:13:02 +0000 (15:13 -0800)
commitc793f8ea15e312789b5b6b4a5e7b0b92315be5cb
tree07a86679170213b7941298b1693acaef5b673fc7
parentb2dbde3ad44f290ded319f00b71dccec90083a50
ice: Fix disabling Rx VLAN filtering with port VLAN enabled

If the user turns on the vf-true-promiscuous-support flag, then Rx VLAN
filtering will be disabled if the VF requests to enable promiscuous
mode. When the VF is in a port VLAN, this is the incorrect behavior
because it will allow the VF to receive traffic outside of its port VLAN
domain. Fortunately this only resulted in the VF(s) receiving broadcast
traffic outside of the VLAN domain because all of the VLAN promiscuous
rules are based on the port VLAN ID. Fix this by setting the
.disable_rx_filtering VLAN op to a no-op when a port VLAN is enabled on
the VF.

Also, make sure to make this fix for both Single VLAN Mode and Double
VLAN Mode enabled devices.

Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops implementations")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
Tested-by: Marek Szlosek <marek.szlosek@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_vf_vsi_vlan_ops.c