]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xen-netfront: avoid crashing on resume after a failure in talk_to_netback()
authorVitaly Kuznetsov <vkuznets@redhat.com>
Thu, 11 May 2017 11:58:06 +0000 (13:58 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 May 2017 01:38:50 +0000 (21:38 -0400)
commitd86b5672b1adb98b4cdd6fbf0224bbfb03db6e2e
treeb16d295eb0fd3a6dbef29514eba363d3b8e82770
parentcb395b2010879a8461aa1b1c37025769708c32cf
xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

Unavoidable crashes in netfront_resume() and netback_changed() after a
previous fail in talk_to_netback() (e.g. when we fail to read MAC from
xenstore) were discovered. The failure path in talk_to_netback() does
unregister/free for netdev but we don't reset drvdata and we try accessing
it after resume.

Fix the bug by removing the whole xen device completely with
device_unregister(), this guarantees we won't have any calls into netfront
after a failure.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netfront.c