]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sat, 6 Jul 2019 13:34:22 +0000 (19:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jul 2019 06:28:36 +0000 (08:28 +0200)
commitf39659f4b3b4742310550a4225bfebf41117f378
treeea6601634169b48dff7235799ba59df9fa415608
parent4528cbb9659195c82bf80745e5abdc14e9ecbb79
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()

commit 89fea04c85e85f21ef4937611055abce82330d48 upstream.

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Cc: <stable@vger.kernel.org>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
[Bartosz: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpiolib-of.c