]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Sun, 7 Apr 2024 06:56:04 +0000 (14:56 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 11 Apr 2024 10:08:34 +0000 (12:08 +0200)
commitf969eb84ce482331a991079ab7a5c4dc3b7f89bf
tree69f7a9d0a380a20ee5c08c2c09effd1b57330577
parent19fa4f2a85d777a8052e869c1b892a2f7556569d
netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get()

nft_unregister_expr() can concurrent with __nft_expr_type_get(),
and there is not any protection when iterate over nf_tables_expressions
list in __nft_expr_type_get(). Therefore, there is potential data-race
of nf_tables_expressions list entry.

Use list_for_each_entry_rcu() to iterate over nf_tables_expressions
list in __nft_expr_type_get(), and use rcu_read_lock() in the caller
nft_expr_type_get() to protect the entire type query process.

Fixes: ef1f7df9170d ("netfilter: nf_tables: expression ops overloading")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c