]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net-sysfs: Call dev_hold always in rx_queue_add_kobject
authorJouni Hogander <jouni.hogander@unikie.com>
Tue, 17 Dec 2019 11:46:34 +0000 (13:46 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 11 Jun 2020 18:05:38 +0000 (19:05 +0100)
commitfd394f42092fe81e28e2564265311b995ec4f5dc
tree41075ec2e82a06225b72fa372f732839d75c9600
parenta7750e90935c481ba6188fb282d87a3368cfcfac
net-sysfs: Call dev_hold always in rx_queue_add_kobject

commit ddd9b5e3e765d8ed5a35786a6cb00111713fe161 upstream.

Dev_hold has to be called always in rx_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: syzbot <syzbot+30209ea299c09d8785c9@syzkaller.appspotmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/net-sysfs.c