]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
powerpc/64s/radix: Fix missing ptesync in flush_cache_vmap
authorNicholas Piggin <npiggin@gmail.com>
Wed, 6 Jun 2018 01:40:08 +0000 (11:40 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 6 Jun 2018 08:50:53 +0000 (18:50 +1000)
commitff5bc793e47b537bf3e904fada585e102c54dd8b
tree3e9676c15faba79021a630df11f9913e0ef98547
parent0a4ec6aa035a52c422eceb2ed51ed88392a3d6c2
powerpc/64s/radix: Fix missing ptesync in flush_cache_vmap

There is a typo in f1cb8f9beb ("powerpc/64s/radix: avoid ptesync after
set_pte and ptep_set_access_flags") config ifdef, which results in the
necessary ptesync not being issued after vmalloc.

This causes random kernel faults in module load, bpf load, anywhere
that vmalloc mappings are used.

After correcting the code, this survives a guest kernel booting
hundreds of times where previously there would be a crash every few
boots (I haven't noticed the crash on host, perhaps due to different
TLB and page table walking behaviour in hardware).

A memory clobber is also added to the flush, just to be sure it won't
be reordered with the pte set or the subsequent mapping access.

Fixes: f1cb8f9beb ("powerpc/64s/radix: avoid ptesync after set_pte and ptep_set_access_flags")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/cacheflush.h