]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Merge branch 'page-refs' (page ref overflow)
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 14 Apr 2019 22:09:40 +0000 (15:09 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 14 Apr 2019 22:09:40 +0000 (15:09 -0700)
Merge page ref overflow branch.

Jann Horn reported that he can overflow the page ref count with
sufficient memory (and a filesystem that is intentionally extremely
slow).

Admittedly it's not exactly easy.  To have more than four billion
references to a page requires a minimum of 32GB of kernel memory just
for the pointers to the pages, much less any metadata to keep track of
those pointers.  Jann needed a total of 140GB of memory and a specially
crafted filesystem that leaves all reads pending (in order to not ever
free the page references and just keep adding more).

Still, we have a fairly straightforward way to limit the two obvious
user-controllable sources of page references: direct-IO like page
references gotten through get_user_pages(), and the splice pipe page
duplication.  So let's just do that.

* branch page-refs:
  fs: prevent page refcount overflow in pipe_buf_get
  mm: prevent get_user_pages() from overflowing page refcount
  mm: add 'try_get_page()' helper function
  mm: make page ref count overflow check tighter and more explicit

1  2 
fs/fuse/dev.c
fs/pipe.c
fs/splice.c
include/linux/mm.h
include/linux/pipe_fs_i.h
kernel/trace/trace.c
mm/gup.c
mm/hugetlb.c

diff --cc fs/fuse/dev.c
Simple merge
diff --cc fs/pipe.c
Simple merge
diff --cc fs/splice.c
Simple merge
Simple merge
Simple merge
Simple merge
diff --cc mm/gup.c
Simple merge
diff --cc mm/hugetlb.c
Simple merge