]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ipv6: Default fib6_type to RTN_UNICAST when not set
authorDavid Ahern <dsahern@gmail.com>
Wed, 19 Jun 2019 17:50:24 +0000 (10:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jun 2019 21:14:05 +0000 (17:14 -0400)
A user reported that routes are getting installed with type 0 (RTN_UNSPEC)
where before the routes were RTN_UNICAST. One example is from accel-ppp
which apparently still uses the ioctl interface and does not set
rtmsg_type. Another is the netlink interface where ipv6 does not require
rtm_type to be set (v4 does). Prior to the commit in the Fixes tag the
ipv6 stack converted type 0 to RTN_UNICAST, so restore that behavior.

Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c

index 0f60eb3a28730d2f21767c54a459ff6b55b0249a..11ad62effd562bf5a3e77875024323ab30c0cb86 100644 (file)
@@ -3184,7 +3184,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
 
        rt->fib6_table = table;
        rt->fib6_metric = cfg->fc_metric;
-       rt->fib6_type = cfg->fc_type;
+       rt->fib6_type = cfg->fc_type ? : RTN_UNICAST;
        rt->fib6_flags = cfg->fc_flags & ~RTF_GATEWAY;
 
        ipv6_addr_prefix(&rt->fib6_dst.addr, &cfg->fc_dst, cfg->fc_dst_len);