]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: phy: sfp: hwmon: Fix scaling of RX power
authorAndrew Lunn <andrew@lunn.ch>
Sun, 21 Jul 2019 16:50:08 +0000 (18:50 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 Jul 2019 18:51:50 +0000 (11:51 -0700)
commit0cea0e1148fe134a4a3aaf0b1496f09241fb943a
tree7afeb1162301bd9cd936c27f6f75ae92f23625ae
parent503d81d428bd598430f7f9d02021634e1a8139a0
net: phy: sfp: hwmon: Fix scaling of RX power

The RX power read from the SFP uses units of 0.1uW. This must be
scaled to units of uW for HWMON. This requires a divide by 10, not the
current 100.

With this change in place, sensors(1) and ethtool -m agree:

sff2-isa-0000
Adapter: ISA adapter
in0:          +3.23 V
temp1:        +33.1 C
power1:      270.00 uW
power2:      200.00 uW
curr1:        +0.01 A

        Laser output power                        : 0.2743 mW / -5.62 dBm
        Receiver signal average optical power     : 0.2014 mW / -6.96 dBm

Reported-by: chris.healy@zii.aero
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 1323061a018a ("net: phy: sfp: Add HWMON support for module sensors")
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/sfp.c