]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
riscv: Fix syscall_get_arguments() and syscall_set_arguments()
authorDmitry V. Levin <ldv@altlinux.org>
Fri, 29 Mar 2019 17:12:21 +0000 (20:12 +0300)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 4 Apr 2019 14:25:31 +0000 (10:25 -0400)
commit10a16997db3d99fc02c026cf2c6e6c670acafab0
treeb26a45e42c002f64ac9e34bf648b1b1b0d18ee1b
parentd08e411397cb6fcb3d3fb075c27a41975c99e88f
riscv: Fix syscall_get_arguments() and syscall_set_arguments()

RISC-V syscall arguments are located in orig_a0,a1..a5 fields
of struct pt_regs.

Due to an off-by-one bug and a bug in pointer arithmetic
syscall_get_arguments() was reading s3..s7 fields instead of a1..a5.
Likewise, syscall_set_arguments() was writing s3..s7 fields
instead of a1..a5.

Link: http://lkml.kernel.org/r/20190329171221.GA32456@altlinux.org
Fixes: e2c0cdfba7f69 ("RISC-V: User-facing API")
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Cc: stable@vger.kernel.org # v4.15+
Acked-by: Palmer Dabbelt <palmer@sifive.com>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
arch/riscv/include/asm/syscall.h