]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regulator: pv88080: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:44:54 +0000 (15:44 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:10:27 +0000 (15:10 +0000)
commit1867af94cfdf37fc70fe67b3d522e78352800196
tree89696e5ac02723643c533a0aa9430e41cd546593
parent978995def0f6030aa6b3b494682f673aca13881b
regulator: pv88080: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/pv88080-regulator.c