]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
exec: Fix NOMMU linux_binprm::exec in transfer_args_to_stack()
authorMax Filippov <jcmvbkbc@gmail.com>
Wed, 20 Mar 2024 18:26:07 +0000 (11:26 -0700)
committerKees Cook <keescook@chromium.org>
Thu, 21 Mar 2024 17:05:47 +0000 (10:05 -0700)
commit2aea94ac14d1e0a8ae9e34febebe208213ba72f7
tree159784ee20375fc7bf45dfda324761fdbfd3615e
parent472874cf7bb34895ae69483338359df84e76f3e1
exec: Fix NOMMU linux_binprm::exec in transfer_args_to_stack()

In NOMMU kernel the value of linux_binprm::p is the offset inside the
temporary program arguments array maintained in separate pages in the
linux_binprm::page. linux_binprm::exec being a copy of linux_binprm::p
thus must be adjusted when that array is copied to the user stack.
Without that adjustment the value passed by the NOMMU kernel to the ELF
program in the AT_EXECFN entry of the aux array doesn't make any sense
and it may break programs that try to access memory pointed to by that
entry.

Adjust linux_binprm::exec before the successful return from the
transfer_args_to_stack().

Cc: <stable@vger.kernel.org>
Fixes: b6a2fea39318 ("mm: variable length argument support")
Fixes: 5edc2a5123a7 ("binfmt_elf_fdpic: wire up AT_EXECFD, AT_EXECFN, AT_SECURE")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Link: https://lore.kernel.org/r/20240320182607.1472887-1-jcmvbkbc@gmail.com
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/exec.c