]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: intel-ish: ipc: handle PIMR before ish_wakeup also clear PISR busy_clear bit
authorSong Hongyan <hongyan.song@intel.com>
Tue, 22 Jan 2019 01:06:26 +0000 (09:06 +0800)
committerJiri Kosina <jkosina@suse.cz>
Thu, 24 Jan 2019 12:10:10 +0000 (13:10 +0100)
commit2edefc056e4f0e6ec9508dd1aca2c18fa320efef
tree9426b4c8f7078d28d79cb8e043a34abf9e871916
parent787a3b4322763284a594a5dd3680508c0bfb20b0
HID: intel-ish: ipc: handle PIMR before ish_wakeup also clear PISR busy_clear bit

Host driver should handle interrupt mask register earlier than wake up ish FW
else there will be conditions when FW interrupt comes, host PIMR register still
not set ready, so move the interrupt mask setting before ish_wakeup.

Clear PISR busy_clear bit in ish_irq_handler. If not clear, there will be
conditions host driver received a busy_clear interrupt (before the busy_clear
mask bit is ready), it will return IRQ_NONE after check_generated_interrupt,
the interrupt will never be cleared, causing the DEVICE not sending following
IRQ.

Since PISR clear should not be called for the CHV device we do this change.
After the change, both ISH2HOST interrupt and busy_clear interrupt will be
considered as interrupt from ISH, busy_clear interrupt will return IRQ_HANDLED
from IPC_IS_BUSY check.

Signed-off-by: Song Hongyan <hongyan.song@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/intel-ish-hid/ipc/ipc.c