]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: stmmac: Re-work the queue selection for TSO packets
authorJose Abreu <Jose.Abreu@synopsys.com>
Mon, 8 Jul 2019 12:26:28 +0000 (14:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Jul 2019 19:36:06 +0000 (12:36 -0700)
commit4993e5b37e8bcb55ac90f76eb6d2432647273747
tree6241791dbe08db302a66a1147aa7e32b9276a5ea
parent36c4357c63f382becfe1d9775ea0872135c8a8ab
net: stmmac: Re-work the queue selection for TSO packets

Ben Hutchings says:
"This is the wrong place to change the queue mapping.
stmmac_xmit() is called with a specific TX queue locked,
and accessing a different TX queue results in a data race
for all of that queue's state.

I think this commit should be reverted upstream and in all
stable branches.  Instead, the driver should implement the
ndo_select_queue operation and override the queue mapping there."

Fixes: c5acdbee22a1 ("net: stmmac: Send TSO packets always from Queue 0")
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c