]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regulator: da9055: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 14:59:59 +0000 (14:59 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:09:58 +0000 (15:09 +0000)
commit5e6afb3832bedf420dd8e4c5b32ed85117c5087d
treeeca3fa61e4a71f60ae4b04d0aea8d4970e5bd433
parent705e2a905a0407c3fffb248b43c8d7d1de6b4e51
regulator: da9055: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: f6130be652d0 ("regulator: DA9055 regulator driver")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9055-regulator.c